quarto: allow overriding extra R and Python packages #211941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 0
|
Do you have an idea why the command |
|
Also quarto is not longer a part of PATH with your submission. |
|
That's very weird, if not overridden, it shouldn't change anything, as it's only concatenating an empty array.
What do you mean by that? |
|
I my case, I add the package to the local scope and quarto is able to have access to them. Why to you want to have an override option? |
As I said: I'm not able to run quarto inside |
|
If I want to execute render the first R example from the documentation, I need to have the If I install in my environment an R package with |
|
Thats how the command is processed: |
|
nixpkgs-review reports:
This is because this PR doesn't modify the quarto package if the package is not overridden, which is why nixpkgs-review doesn't try to build quarto: the hash is the same as on master. This is also why quarto is not part of your environment. |
I see, that would it make less hacky to add additional packages. Well know I see the usage, thank you. |
So you mean, I have to install quarto first and then review the changes? |
|
Yepp, that's it. Now it works, a bit strange behavior of the review function, but anyway i have it for the future. Thank you, for the suggestion! |
MrTarantoga
approved these changes
Jan 22, 2023
SuperSandro2000
added
the
12.approvals: 1
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Tested by running a
.qmdfile needing ggplot2 and a.qmdfile needing numpy and matplotlib.Pinging @MrTarantoga
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes