Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixosTests.systemd-cryptenroll: mark as not broken #213182

Merged
merged 1 commit into from
Jan 28, 2023
Merged

nixosTests.systemd-cryptenroll: mark as not broken #213182

merged 1 commit into from
Jan 28, 2023

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Jan 28, 2023

Since 568d6fc, this has been fixed and actually succeeds.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@flokli
nixosTests.systemd-cryptenroll: mark as not broken
5328e13 
Since 568d6fc, this has been fixed and
actually succeeds.
@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Jan 28, 2023
@flokli flokli mentioned this pull request Jan 28, 2023
Closed
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Jan 28, 2023
@figsoda figsoda mentioned this pull request Jan 28, 2023
Merged
@NickCao NickCao merged commit fc975d6 into NixOS:staging Jan 28, 2023
@flokli flokli deleted the systemd-cryptenroll-not-broken branch January 28, 2023 22:59
@flokli flokli mentioned this pull request Feb 3, 2023
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickCao NickCao NickCao approved these changes

@RaitoBezarius RaitoBezarius Awaiting requested review from RaitoBezarius

@ElvishJerricco ElvishJerricco Awaiting requested review from ElvishJerricco

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flokli @NickCao