Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rime-cli: init at 0.0.3 #214844

Merged
merged 1 commit into from
Feb 6, 2023
Merged

rime-cli: init at 0.0.3 #214844

merged 1 commit into from
Feb 6, 2023

Conversation

urandom2
Copy link
Contributor

@urandom2 urandom2 commented Feb 6, 2023

Description of changes

Fixes #214147

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1797

@figsoda
Copy link
Member

figsoda commented Feb 6, 2023

@Freed-Wu the rime-cli you linked to seems to be different from the one coc-rime depends on

@Freed-Wu
Copy link
Contributor

@Freed-Wu the rime-cli you linked to seems to be different from the one coc-rime depends on

It's my fault. coc-rime use this rime-cli. I use it by a flake.nix. In that flake.nix, I name it as rime-cli-server to avoid conflict. Maybe we can provide packages in nixpkgs for coc-rime and rime-cli-server? @tonyfettes, maybe we can rename rime-cli to rime-cli-server to avoid conflict?

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jul 12, 2023

You linked two times the same rime-cli repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rime-cli
7 participants