keepassx{,2}: drop #216748
Merged
keepassx{,2}: drop #216748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
|
Drafting until I get a chance to fix the eval error. |
|
Looks like you accidentally deleted Also, it looks like like your change to the See 9f29abc for a similar change. |
winterqt
force-pushed
the
drop-keepassx
branch
from
0bd9b39
to
1df0640
Compare
winterqt
force-pushed
the
drop-keepassx
branch
from
1df0640
to
aa9229a
Compare
|
Thanks @ajs124, should be good now. Should I squash the two commits, does it make sense to have separate commits for them? |
|
You seem to have forgotten to add the new directory. That or I'm misreading the diff. I don't really have an opinion on squashing these, tbh. |
winterqt
force-pushed
the
drop-keepassx
branch
3 times, most recently
from
b104f8a
to
4efe5c1
Compare
Upstream has officially abandoned the project as of 2021 [0], there's been no release since 2016, it uses the EoL Qt 4, and alternatives like KeePassXC exist. Also move KeePassXC to its own directory -- it doesn't make sense to have it in KeePassX's folder anymore. [0]: https://www.keepassx.org/index.html%3Fp=636.html
winterqt
force-pushed
the
drop-keepassx
branch
from
4efe5c1
to
1301a1a
Compare
ofborg
bot
added
8.has: clean-up
10.rebuild-darwin: 0
sumnerevans
added a commit
to nix-community/home-manager
that referenced
this pull request
Jan 25, 2024
This removes the services.keepassx module and all options related to it. This is because KeePassX has been unmaintaned for a long time, and the migration path to KeePassXC is not clear. Note, this package probably hasn't worked for nearly a year since the package was removed from Nixpkgs: NixOS/nixpkgs#216748 Closes #4949 Signed-off-by: Sumner Evans <me@sumnerevans.com>
6 tasks
rycee
pushed a commit
to nix-community/home-manager
that referenced
this pull request
Jan 25, 2024
This removes the services.keepassx module and all options related to it. This is because KeePassX has been unmaintaned for a long time, and the migration path to KeePassXC is not clear. Note, this package probably hasn't worked for nearly a year since the package was removed from Nixpkgs: NixOS/nixpkgs#216748 Closes #4949 Signed-off-by: Sumner Evans <me@sumnerevans.com>
fufexan
pushed a commit
to fufexan/home-manager
that referenced
this pull request
Feb 24, 2024
This removes the services.keepassx module and all options related to it. This is because KeePassX has been unmaintaned for a long time, and the migration path to KeePassXC is not clear. Note, this package probably hasn't worked for nearly a year since the package was removed from Nixpkgs: NixOS/nixpkgs#216748 Closes nix-community#4949 Signed-off-by: Sumner Evans <me@sumnerevans.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Upstream has officially abandoned the project as of 2021 0, there's been no release since 2016, it uses the EoL Qt 4, and alternatives like KeePassXC exist.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)