solc: 0.8.13 -> 0.8.19

[fare]

Description of changes

Latest upstream release, including many security fixes.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[Philipp-M]

Result of nixpkgs-review pr 219240 run on x86_64-linux 1

1 package built:

• solc

[Philipp-M]

LGTM, I would advocate to merge this, as the current solc on master seems to be broken.

[fare]

Fixes #182498

[fare]

Fixes #122568

[viraptor]

Testing still fails with ModuleNotFoundError: No module named 'requests' on linux

[fare]

Testing still fails with ModuleNotFoundError: No module named 'requests' on linux

Weird. It passed for me locally. I rebased to latest master in case it helps.

[fare]

Aha, I need to tweak the python3 in nativeCheckInputs to add some python packages so solc.passthru.tests will work, when solc without tests does work already. Will run the tests...

[fare]

How with nix-shell do I retry the tests with additional dependencies without rebuilding everything from scratch every time I change something?

[fare]

Latest issue: some tests really want to execute in a tty. How do I run them in a pty?

OK
Testing LSP...(B
Traceback (most recent call last):
  File "/build/source/./scripts/../test/lsp.py", line 31, in <module>
    tty.setcbreak(sys.stdin.fileno())
  File "/nix/store/0n4y44dnaxafqs7cg625aldrb152x7bx-python3-3.10.10/lib/python3.10/tty.py", line 32, in setcbreak
    mode = tcgetattr(fd)
termios.error: (25, 'Inappropriate ioctl for device')
error: builder for '/nix/store/l74pnb5kla4ivqdarbwahp6q6r0fcacn-solc-0.8.19.drv' failed with exit code 1;
       last 10 log lines:
       > Ran 77 tests in 0.018s
       >
       > OK   
       > Testing LSP...(B
       > Traceback (most recent call last):
       >   File "/build/source/./scripts/../test/lsp.py", line 31, in <module>
       >     tty.setcbreak(sys.stdin.fileno())
       >   File "/nix/store/0n4y44dnaxafqs7cg625aldrb152x7bx-python3-3.10.10/lib/python3.10/tty.py", line 32, in setcbreak
       >     mode = tcgetattr(fd)
       > termios.error: (25, 'Inappropriate ioctl for device')
       For full logs, run 'nix log /nix/store/l74pnb5kla4ivqdarbwahp6q6r0fcacn-solc-0.8.19.drv'.

[fare]

I managed to patch the python script so it avoids requiring a tty, and added a few more check dependencies.

It's now at the point where it wants evmone to compile, and as I read the documentation I see it wants hera, too. Sigh. That's a much taller order than fixing the immediate build.

[fare]

Trying to add an evmone package to nixpkgs, and it's another exercise in yak shaving.

[fare]

OK, I give up for now. Too many other more important things to do in my life and for my job.

The patch offered is not a regression. Obviously these tests have never worked in Nix. Getting them to work would be a couple few days of work for an engineer.

[fare]

I punted and made this patch pass the tests by commenting out the invocation of the script that depends on evmone and more, with a TODO comment. This way, solc can fix the known build issues, and still run a lot of tests. Further fixing the tests will require a lot of work.

[fare]

To upstream my patch to a solidity test: ethereum/solidity#14057

[fare]

Can we get this merged? The commented out test is not a regression.

[brianmcgee]

Result of nixpkgs-review pr 219240 run on x86_64-linux 1

1 package built:

• solc