RaspberryPi boot loader: fix booting Raspberry Pi 3 #21988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Raspberry Pi 3 seems to need the .DTB file when booting the kernel, so we must copy it to /boot when installing a new kernel.
The Raspberry Pi boot loader was deleting all xx-initrd text files (which simply contain the path to the actual initrd files) just after having created them. The code was actually trying to delete real, obsolete initrd files, which are named <hash>-initrd-initrd (after path cleaning), but the glob was catching the other files as well.
|
I don't use/maintain this code (I use the U-Boot / extlinux stuff). So all @viric. Sounds reasonable to me though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This PR makes the Raspberry Pi boot loader boot the Raspberry Pi 3 correctly (apart from not generating/overwriting
/boot/config.txt, like it would be necessary for the other Raspberry Pi models).In addition to what was already being done for the other Raspberry Pi models, this basically just copies the .DTB files of the default installed kernel to
/boot, and deletes any old .DTB files that could have been lying around in that directory.I have also fixed a bug where all
/boot/old/xx-initrdfiles (wherexxis a small number between 1 and the number of system profile generations) were getting accidentally deleted after having been created.Note that this PR does not copy old .DTB files to
/boot/old, especially because maintaining the same deduplicating scheme seems like it would greatly complicate the code (but perhaps I am mistaken). However, there's nothing in this PR that would prevent that from being done in the future.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)