Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patchelfStable: revert "0.15.0 -> 0.17.2" #222207

Closed
wants to merge 1 commit into from
Closed

patchelfStable: revert "0.15.0 -> 0.17.2" #222207

wants to merge 1 commit into from

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Mar 20, 2023 •
edited
Loading

This reverts commit 9b3b562.

patchelf-0.17.2 caused regressions at least in emacs and ldc:
NixOS/patchelf#482

They are quite hard to diagnose without bisection. Let's revert back to 0.15.0.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@trofi
patchelfStable: revert "0.15.0 -> 0.17.2"
7a82250 
This reverts commit 9b3b562.

`patchelf-0.17.2` caused regressions at least in `emacs` and `ldc`:
    NixOS/patchelf#482

They are quite hard to diagnose without bisection. Let's revert back to
0.15.0.
@trofi trofi mentioned this pull request Mar 20, 2023
Merged
@vcunat vcunat added the 2.status: duplicate This is a duplicate of another issue or PR label Mar 20, 2023
@vcunat
Copy link
Member

vcunat commented Mar 20, 2023

Done in ce15577

@vcunat vcunat closed this Mar 20, 2023
@trofi trofi deleted the patchelf-revert branch March 20, 2023 16:28
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: duplicate This is a duplicate of another issue or PR 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trofi @vcunat