nixos/tests/installer: test /boot on ZFS #223412
Conversation
| @@ -634,6 +634,7 @@ in | |||
| // { | |||
| "zfs/zed.d/zed.rc".text = zedConf; | |||
| "zfs/zpool.d".source = "${cfgZfs.package}/etc/zfs/zpool.d/"; | |||
| "zfs/compatibility.d".source = "${cfgZfs.package}/share/zfs/compatibility.d/"; | |||
There was a problem hiding this comment.
Could you do a separate commit to introduce this change and explain why is it needed?
|
Also, sorry probably due to me, conflicts. :) |
|
Apparently the |
Luflosi
force-pushed
the
test-boot-from-zfs
branch
from
6afd9ef
to
b2596f4
Compare
Let's test / on ZFS and /boot on ZFS in separate tests since the GRUB integration for ZFS seems to be not very well maintained. If the test breaks in the future it's easier to figure out that ZFS on /boot is at fault and either fix the issue or disable the test. The new test creates a ZFS pool where all features not compatible with GRUB2 are disabled. The dataset is then mounted on /boot and we check that the installer correctly generates a bootable configuration. Try to use as many ZFS features as possible to verify that GRUB can handle them.
Luflosi
force-pushed
the
test-boot-from-zfs
branch
from
b2596f4
to
c351a84
Compare
|
cc @misuzu @ElvishJerricco and @RaitoBezarius |
|
Would you prefer a different combination of filesystems? Perhaps ZFS for both / and /boot? |
|
As long as upstream has documentation showing using a boot zfs pool, we should test it. This PR seems to fulfill that need. https://openzfs.github.io/openzfs-docs/Getting%20Started/NixOS/Root%20on%20ZFS.html @ofborg test installer.separateBootZfs installer.zfsroot |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1313 |
Description of changes
Let's test / on ZFS and /boot on ZFS in separate tests since the GRUB integration for ZFS seems to be not very well maintained.
If the test breaks in the future it's easier to figure out that ZFS on /boot is at fault and either fix the issue or disable the test.
The new test creates a ZFS pool where all features not compatible with GRUB2 are disabled. The dataset is then mounted on /boot and we check that the installer correctly generates a bootable configuration.
Try to use as many ZFS features as possible to verify that GRUB can handle them.
This PR adds a test to have some more confidence in the change proposed in #195805.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)