Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dtrx: 8.4.0 -> 8.5.0 #225953

Merged
merged 2 commits into from
Apr 21, 2023
Merged

dtrx: 8.4.0 -> 8.5.0 #225953

merged 2 commits into from
Apr 21, 2023

Conversation

puffnfresh
Copy link
Contributor

Combined with a fix for: dtrx-py/dtrx#45

Not sure what changed on nixpkgs side to start triggering this issue. Maybe a change in setuptools?

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@puffnfresh
dtrx: 8.4.0 -> 8.5.0
9e78b53 
Combined with a fix for: dtrx-py/dtrx#45

Not sure what changed on nixpkgs side to start triggering this issue.
Maybe a change in setuptools?
@ofborg ofborg bot requested a review from spwhitt April 13, 2023 00:45
@SuperSandro2000
Copy link
Member

Not sure what changed on nixpkgs side to start triggering this issue. Maybe a change in setuptools?

probably an update to dependencies like setuptools or similar

@puffnfresh @SuperSandro2000
dtrx: define postPatch instead of patchPhase
6c01104 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@SuperSandro2000 SuperSandro2000 merged commit aec122a into NixOS:master Apr 21, 2023
@noahp
Copy link

noahp commented Apr 27, 2023

Correct, this was due to setuptools update tripping on a pretty sketchy bit in the dtrx setup.cfg. It's now fixed in dtrx 8.5.1 (also pushed to PyPI):
https://github.com/dtrx-py/dtrx/releases/tag/8.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@spwhitt spwhitt Awaiting requested review from spwhitt

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@puffnfresh @SuperSandro2000 @noahp