Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pgadmin: 6.21 -> 7.0 #226675

Merged
merged 3 commits into from
Apr 23, 2023
Merged

Pgadmin: 6.21 -> 7.0 #226675

merged 3 commits into from
Apr 23, 2023

Conversation

gador
Copy link
Member

@gador gador commented Apr 17, 2023

Description of changes

Update of Pgadmin to current version 7 Changelog: https://www.pgadmin.org/docs/pgadmin4/latest/release_notes_7_0.html

Includes updates to

This is a major release and enables us to remove all of the custom overrides. I decided to still keep the scope "umbrella" in case the next minor update will require an older version of some python package.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@gador
Copy link
Member Author

gador commented Apr 18, 2023

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 226675 run on x86_64-linux 1

22 packages built:
  • appdaemon
  • appdaemon.dist
  • azure-cli
  • azure-cli.dist
  • gdbgui
  • gdbgui.dist
  • onionshare
  • onionshare-gui
  • onionshare-gui.dist
  • onionshare.dist
  • pgadmin4
  • pgadmin4-desktopmode
  • pgadmin4-desktopmode.dist
  • pgadmin4.dist
  • python310Packages.azure-mgmt-resource
  • python310Packages.azure-mgmt-resource.dist
  • python310Packages.flask-socketio
  • python310Packages.flask-socketio.dist
  • python311Packages.azure-mgmt-resource
  • python311Packages.azure-mgmt-resource.dist
  • python311Packages.flask-socketio
  • python311Packages.flask-socketio.dist

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2110

gador and others added 3 commits April 21, 2023 11:04
Changelog: https://github.com/miguelgrinberg/Flask-SocketIO/blob/main/CHANGES.md

Signed-off-by: Florian Brandes <florian.brandes@posteo.de>
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Changelog: https://www.pgadmin.org/docs/pgadmin4/latest/release_notes_7_0.html

Signed-off-by: Florian Brandes <florian.brandes@posteo.de>
@bendlas
Copy link
Contributor

bendlas commented Apr 30, 2023

I've got issues after this update:

The web interface tries to access /static/js/generated/* files, which lead to 404 errors. I believe ther is a yarn run bundle step missing.

@gador gador mentioned this pull request Apr 30, 2023
13 tasks
@gador
Copy link
Member Author

gador commented Apr 30, 2023

@bendlas thank you for report!

I believe #229184 should fix the issue.

gador added a commit to gador/nixpkgs that referenced this pull request Apr 30, 2023
since the new release of 7.0, the `generated` directory isn't included
in the tarball anymore. This commit will build the frontend so
pgadmin can function again.

Fixes NixOS#226675 (comment)

Also this commit will switch to the Github source and will not
need the package.json and yarn.{lock,nix} files anymore, since the
mkYarnModules part has been removed.

Also, since we don't depend on those files anymore and we switched
to Github, the `update.sh` script has been superseeded and isn't
needed anymore.

Signed-off-by: Florian Brandes <florian.brandes@posteo.de>
gador added a commit to gador/nixpkgs that referenced this pull request Apr 30, 2023
since the new release of 7.0, the `generated` directory isn't included
in the tarball anymore. This commit will build the frontend so
pgadmin can function again.

Fixes NixOS#226675 (comment)

Also this commit will switch to the Github source and will not
need the package.json and yarn.{lock,nix} files anymore, since the
mkYarnModules part has been removed.

Also, since we don't depend on those files anymore and we switched
to Github, the `update.sh` script has been superseeded and isn't
needed anymore.

Signed-off-by: Florian Brandes <florian.brandes@posteo.de>
@emilylange emilylange mentioned this pull request May 4, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants