Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obs-studio-plugins.advanced-scene-switcher: 1.20.5 -> 1.21.1 #228065

Merged
merged 1 commit into from
May 9, 2023
Merged

obs-studio-plugins.advanced-scene-switcher: 1.20.5 -> 1.21.1 #228065

merged 1 commit into from
May 9, 2023

Conversation

takov751
Copy link
Contributor

@takov751 takov751 commented Apr 25, 2023

description of changes

https://github.com/WarmUpTill/SceneSwitcher/releases/tag/1.21.1

Things done

Built on platform(s)

  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Copy link
Member

@paveloom paveloom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Completely forgot to subscribe to the upstream updates. I've tested the patch and it seems to be working fine.

Please, change your commit message to obs-studio-plugins.advanced-scene-switcher: 1.20.5 -> 1.21.1, as per the guidelines.

@takov751
Copy link
Contributor Author

@paveloom my bad, i will do so when i am back home

@takov751
Copy link
Contributor Author

I have amended the comment, thanks for reminding me.

@ofborg ofborg bot requested a review from paveloom April 26, 2023 02:37
Copy link
Member

@paveloom paveloom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@figsoda figsoda added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Apr 30, 2023
@lheckemann lheckemann merged commit a3721d5 into NixOS:master May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants