Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages: Add maintainer shlok #229459

Merged
merged 1 commit into from
May 2, 2023
Merged

haskellPackages: Add maintainer shlok #229459

merged 1 commit into from
May 2, 2023

Conversation

shlok
Copy link
Contributor

@shlok shlok commented May 2, 2023

No description provided.

@shlok shlok mentioned this pull request May 2, 2023
Merged
2 tasks
@cdepillabout
Copy link
Member

Thanks!

@cdepillabout cdepillabout merged commit 394d6a8 into NixOS:haskell-updates May 2, 2023
sternenseemann added a commit that referenced this pull request May 3, 2023
@sternenseemann
Revert "haskellPackages: Add maintainer shlok"
a6bb2cc 
This reverts commit ad38216 and
regenerates hackage-packages.nix.

Reason for Revert: There is no lib.maintainers.shlok.

Reference #229459.
@sternenseemann
Copy link
Member

I've reverted this PR in a6bb2cc. Maintainers need a corresponding entry in maintainers/maintainer-list.nix before they can take over maintainership of any package. Please re-create this PR which also adds such an entry.

@cdepillabout
Copy link
Member

@sternenseemann Ah, good catch! Sorry for that.

@shlok
Copy link
Contributor Author

shlok commented May 3, 2023

@sternenseemann Thanks for the feedback. Here is the new PR: #229647

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasew lucasew lucasew approved these changes

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

@maralorn maralorn Awaiting requested review from maralorn

Assignees
No one assigned
Labels
6.topic: haskell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shlok @cdepillabout @sternenseemann @lucasew