Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bonsai: init at 1.0.2 #233892

Merged
merged 1 commit into from
Jan 15, 2024
Merged

bonsai: init at 1.0.2 #233892

merged 1 commit into from
Jan 15, 2024

Conversation

uninsane
Copy link
Contributor

Description of changes

bonsai's an event-triggered state machine implemented as a daemon. it's used by sxmo to make button-mapping highly configurable by the user.

upstreamed from here, where i've been using it within sxmo deployed to a NixOS Pinephone for a few days without issue.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux (via binfmt emulation)
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@uninsane uninsane requested review from wentam and chuangzhu May 24, 2023 22:52
@uninsane uninsane mentioned this pull request Aug 3, 2023
Merged
12 tasks
@uninsane uninsane force-pushed the pr/sane/bonsai-init branch 2 times, most recently from b5b27d6 to 845aaf8 Compare August 9, 2023 03:15
@uninsane
Copy link
Contributor Author

uninsane commented Nov 6, 2023

bumped the hare-ev and hare-json deps to the commits mentioned above and applied the rest of the feedback. builds and runs fine for me here. thanks for the feedback & sorry it took me so long to get to addressing it!

FliegendeWurst
FliegendeWurst reviewed Nov 6, 2023
View reviewed changes
Copy link
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 233892 run on x86_64-linux 1

3 packages built:
  • bonsai
  • hare-ev
  • hare-json

pkgs/development/libraries/hare-ev/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/bonsai/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/bonsai/default.nix Outdated Show resolved Hide resolved
@chayleaf
Copy link
Contributor

Result of nixpkgs-review pr 233892 run on x86_64-linux 1

3 packages built:
  • bonsai
  • hare-ev
  • hare-json

@uninsane uninsane changed the title bonsai: init at 1.0.0 bonsai: init at 1.0.2 Nov 27, 2023
@uninsane
Copy link
Contributor Author

updated to bonsai 1.0.2, and the hare-ev/hare-json dependencies alongside that (and redeployed, works as expected). this is possible because nixpkgs updated hare/harec recently to a version compatible with 1.0.2.

the diff should look about the same. i took the liberty to add the necessary hare flags to support cross-compilation while i was at it though (i think the flags for that can be added to the hare setup hook, after we verify it works with the other hare packages).

@uninsane
Copy link
Contributor Author

Result of nixpkgs-review pr 233892 run on x86_64-linux 1

3 packages built:
  • bonsai
  • hare-ev
  • hare-json

@uninsane uninsane mentioned this pull request Dec 15, 2023
Merged
13 tasks
@uninsane uninsane marked this pull request as draft December 15, 2023 17:53
@uninsane
Copy link
Contributor Author

moved to draft: the hare-json dependency has been merged into nixpkgs; hare-ev is out for PR. once the latter is merged i'll reopen this PR with only the bonsai package.

@onemoresuza onemoresuza mentioned this pull request Dec 15, 2023
Merged
13 tasks
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1319

@uninsane uninsane marked this pull request as ready for review December 20, 2023 09:22
pbsds
pbsds approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@pbsds pbsds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 233892 run on x86_64-linux 1

1 package built:
  • bonsai

@pbsds pbsds merged commit 005862f into NixOS:master Jan 15, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wegank wegank wegank left review comments

@pbsds pbsds pbsds approved these changes

@chayleaf chayleaf chayleaf approved these changes

@FliegendeWurst FliegendeWurst FliegendeWurst approved these changes

@wentam wentam Awaiting requested review from wentam

@chuangzhu chuangzhu Awaiting requested review from chuangzhu

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12.approvals: 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@uninsane @chayleaf @nixos-discourse @pbsds @wegank @FliegendeWurst