Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

httping 2.5: fetch over HTTPS + license info #23401

Merged
merged 1 commit into from
Mar 2, 2017
Merged

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Mar 2, 2017

Motivation for this change

Follow-up to #23350 + #23369

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@c0bw3b, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nckx, @rickynils and @ndowens to be potential reviewers.

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Mar 2, 2017

@joachifm added license info and HTTPS source URL through this PR

@nckx nckx merged commit a9700f7 into NixOS:master Mar 2, 2017
@nckx
Copy link
Member

nckx commented Mar 2, 2017

Thanks!

@c0bw3b c0bw3b deleted the pkg/httping branch March 2, 2017 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants