qnotero: fix #23438

[nico202]

Motivation for this change

#23438

As commented in line 20-21, I could just use "../../../" to fix the path. However I'm not sure if things will keep the way they are, so I thought realpath is less sensible to changes. I have no problem in just replacing it

[mention-bot]

@nico202, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer.

[bennofs]

@nico202 Thx for looking at this! If found another way to achieve the intended result, which also reduces the amount of patching necessary:

diff --git a/pkgs/applications/office/qnotero/default.nix b/pkgs/applications/office/qnotero/default.nix
index 5076a8f586..7b6bf14681 100644
--- a/pkgs/applications/office/qnotero/default.nix
+++ b/pkgs/applications/office/qnotero/default.nix
@@ -18,17 +18,12 @@ python3Packages.buildPythonPackage rec {
 
   patchPhase = ''
       substituteInPlace ./setup.py \
-        --replace "/usr/share" "$out/usr/share"
+        --replace "/usr/share" "usr/share"
 
       substituteInPlace ./libqnotero/_themes/default.py \
         --replace "/usr/share" "$out/usr/share"
   '';
 
-  postInstall = ''
-      mkdir -p "$out/usr/share/qnotero"
-      mv resources "$out/usr/share/qnotero"
-  '';
-
   meta = {
     description = "Quick access to Zotero references";
     homepage = http://www.cogsci.nl/software/qnotero;

Perhaps this would be a less-hacky solution to the problem?

[grahamc]

Yes please on the patch.

[nico202]

@bennofs @grahamc you mean like that? Seems to work :)