Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

easyabc: init at 1.3.8.6 #237197

Merged
merged 1 commit into from
Jun 23, 2023
Merged

easyabc: init at 1.3.8.6 #237197

merged 1 commit into from
Jun 23, 2023

Conversation

mausch
Copy link
Member

@mausch mausch commented Jun 11, 2023

Description of changes

https://easyabc.sourceforge.net/

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@mausch
Copy link
Member Author

mausch commented Jun 11, 2023

It builds on aarch64-linux but not on x86_64-linux? Makes no sense... 😕
BTW It Works On My Machine (x86_64-linux)

EDIT: broken due to #236949

pkgs/applications/audio/easyabc/default.nix Outdated Show resolved Hide resolved
owner = "jwdj";
repo = pname;
rev = "6461b2c14280cb64224fc5299c31cfeef9b7d43c";
sha256 = "sha256-leC3A4HQMeJNeZXArb3YAYr2mddGPcws618NrRh2Q1Y=";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sha256 = "sha256-leC3A4HQMeJNeZXArb3YAYr2mddGPcws618NrRh2Q1Y=";
hash = "sha256-leC3A4HQMeJNeZXArb3YAYr2mddGPcws618NrRh2Q1Y=";

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied in 5fa3e97

pkgs/applications/audio/easyabc/default.nix Show resolved Hide resolved
pkgs/applications/audio/easyabc/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/easyabc/default.nix Show resolved Hide resolved
pkgs/applications/audio/easyabc/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/easyabc/default.nix Show resolved Hide resolved
pkgs/applications/audio/easyabc/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/easyabc/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/easyabc/default.nix Show resolved Hide resolved
pkgs/applications/audio/easyabc/default.nix Outdated Show resolved Hide resolved
@mausch
Copy link
Member Author

mausch commented Jun 17, 2023

@AndersonTorres Applied all your suggestions, thanks.

@AndersonTorres AndersonTorres merged commit 644fed2 into NixOS:master Jun 23, 2023
@mausch mausch deleted the easyabc branch June 23, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants