Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emacs: disable withXwidgets on darwin #237681

Merged
merged 1 commit into from
Jun 14, 2023
Merged

emacs: disable withXwidgets on darwin #237681

merged 1 commit into from
Jun 14, 2023

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jun 14, 2023

Description of changes

withXwidgets requires webkitgtk, which is marked as broken on Darwin.

cc: @AndersonTorres related to #235859

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@marsam
emacs: disable withXwidgets on darwin
104992f 
withXwidgets requires webkitgtk, which is marked as broken on Darwin.
@marsam marsam requested a review from adisbladis as a code owner June 14, 2023 04:53
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jun 14, 2023
@github-actions github-actions bot added the 6.topic: emacs Text editor label Jun 14, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jun 14, 2023
@wegank
Copy link
Member

wegank commented Jun 14, 2023

Result of nixpkgs-review pr 237681 run on aarch64-darwin 1

3 packages built:
  • emacs-gtk (emacs28-gtk3)
  • emacs29-gtk3
  • emacs29-pgtk

@adisbladis adisbladis merged commit c5c01f0 into NixOS:master Jun 14, 2023
@github-actions github-actions bot mentioned this pull request Jun 14, 2023
Merged
1 task
@github-actions
Copy link
Contributor

Successfully created backport PR for release-23.05:

socksy added a commit to socksy/emacs that referenced this pull request Aug 22, 2023
@socksy
Remove withXwidgets :(
666cd9e 
Unfortunately as of NixOS/nixpkgs#237681
the withXwidgets param has been disable on macos so this won't build
with this dependency. I don't fully understand why, but in the interest
of getting the build working...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis Awaiting requested review from adisbladis

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

@lovek323 lovek323 Awaiting requested review from lovek323

@jwiegley jwiegley Awaiting requested review from jwiegley

@Atemu Atemu Awaiting requested review from Atemu

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: emacs Text editor 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marsam @wegank @adisbladis