scaphandre: init at 0.5.0 #238462
Merged
scaphandre: init at 0.5.0 #238462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaelreyrol
force-pushed
the
init-scaphandre
branch
from
4f37601
to
a1505af
Compare
gaelreyrol
force-pushed
the
init-scaphandre
branch
from
a1505af
to
64ce11e
Compare
ofborg
bot
added
8.has: package (new)
pkgs/servers/scaphandre/default.nix
Outdated
| dieHook | ||
| ]; | ||
| } '' | ||
| ${scaphandre}/bin/scaphandre stdout -t 4 > $out || die "Scaphandre failed to measure consumption" |
There was a problem hiding this comment.
didn't you say you need intel_rapl_common? how is it supposed to work on non-Intel machines?
There was a problem hiding this comment.
Yes it does, I thought that when building the package it was going through the tests. Should I extract it into a nixosTest ? According to the compatibility page, the sensor is available on Intel & AMD but I don't know how to handle that.
There was a problem hiding this comment.
I added a nixosTest to ensure kernel module intel_rapl_common is activated.
RaitoBezarius
requested changes
Jun 25, 2023
gaelreyrol
force-pushed
the
init-scaphandre
branch
from
64ce11e
to
26b3fc1
Compare
gaelreyrol
force-pushed
the
init-scaphandre
branch
from
26b3fc1
to
354e63f
Compare
github-actions
bot
added
the
6.topic: nixos
12 tasks
drupol
reviewed
Jun 25, 2023
drupol
approved these changes
Jun 26, 2023
mccurdyc
pushed a commit
to mccurdyc/nixpkgs
that referenced
this pull request
Jul 3, 2023
* scaphandre: init at 0.5.0 * Update pkgs/servers/scaphandre/default.nix --------- Co-authored-by: Pol Dellaiera <pol.dellaiera@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Scaphandre is an energy consumption metrology agent that supports various time series databases such as prometheus.
I deployed this package on three hosts to expose metrics to prometheus and it works fine, the only requirement is to have
intel_rapl_commonkernel module enable.As it is a new package, it could be backported to 23.05.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)