nixos/luks: offer rekeying procedure at early boot time #240411
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to GHSA-3rvf-24q2-24ww We decided to offer rekeying procedures in NixOS based on `nixos.rekey` command line argument at boot in stage 1. This is automatically enabled if we heuristically find you are affected by the vulnerability mentioned above.
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
labels
nikstur
reviewed
Jun 28, 2023
| @@ -222,6 +229,9 @@ for o in $(cat /proc/cmdline); do | |||
| boot.panic_on_fail|stage1panic=1) | |||
| panicOnFail=1 | |||
| ;; | |||
| nixos.rekey) | |||
There was a problem hiding this comment.
Do we really want this? Looks like a feature creeping in that might be hard/annoying to get rid of again.
wegank
added
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Due to GHSA-3rvf-24q2-24ww We decided to offer rekeying procedures in NixOS based on
nixos.rekeycommand line argument at boot in stage 1.This is automatically enabled if we heuristically find you are affected by the vulnerability mentioned above.
This is a very early sneak peek because I will finish this tomorrow hopefully.
TODO:
luksroot.nixThings done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)