Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mercure: init at 0.15.5 #242913

Merged
merged 1 commit into from
Nov 4, 2023
Merged

Conversation

gaelreyrol
Copy link
Contributor

@gaelreyrol gaelreyrol commented Jul 11, 2023

Description of changes

This PR adds mercure package: https://github.com/dunglas/mercure

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@gaelreyrol
Copy link
Contributor Author

@GrahamcOfBorg build mercure-legacy

@gaelreyrol gaelreyrol marked this pull request as ready for review July 14, 2023 10:28
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit confused. The packages use exactly the same source. All the arguments are the same besides the subPackages and excludedPackages. Why is upstream maintaining both of these variants in the same repo / branch? Perhaps only one variant should be included in Nixpkgs. Even if not, could you at least merge the expressions into one?

I'd suggest the following:

Write a single mercure/default.nix file, with a , legacy ? false argument. Then, write a comment near it saying something like this:

# Enabling the legacy build will build only Go's subPackages <...>, 
# as documented upstream here: <link>

And in all-packages.nix, don't add mercure-legacy, especially if using it is considered discouraged, especially if it is called "legacy". Perhaps in the comment above, you can mention that in order to build it you have to add the package (pkgs.mercure.override { legacy = true;}) to one's NixOS / home-manager configuration.

@gaelreyrol gaelreyrol changed the title mercure: init at 0.14.10, mercure-legacy: init at 0.14.10 mercure: init at 0.15.5 Nov 4, 2023
@gaelreyrol
Copy link
Contributor Author

@doronbehar Thanks for your feedback, I've decided to remove the legacy package as I don't think it is worth maintaining it.

Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Ping me when CI is green.

@doronbehar doronbehar merged commit eb09edd into NixOS:master Nov 4, 2023
25 of 26 checks passed
@gaelreyrol gaelreyrol deleted the mercure-init-0.14.10 branch November 4, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants