-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mercure: init at 0.15.5 #242913
mercure: init at 0.15.5 #242913
Conversation
57e4b20
to
94dbe81
Compare
@GrahamcOfBorg build mercure-legacy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a bit confused. The packages use exactly the same source. All the arguments are the same besides the subPackages
and excludedPackages
. Why is upstream maintaining both of these variants in the same repo / branch? Perhaps only one variant should be included in Nixpkgs. Even if not, could you at least merge the expressions into one?
I'd suggest the following:
Write a single mercure/default.nix
file, with a , legacy ? false
argument. Then, write a comment near it saying something like this:
# Enabling the legacy build will build only Go's subPackages <...>,
# as documented upstream here: <link>
And in all-packages.nix
, don't add mercure-legacy
, especially if using it is considered discouraged, especially if it is called "legacy". Perhaps in the comment above, you can mention that in order to build it you have to add the package (pkgs.mercure.override { legacy = true;})
to one's NixOS / home-manager configuration.
94dbe81
to
13c1993
Compare
@doronbehar Thanks for your feedback, I've decided to remove the legacy package as I don't think it is worth maintaining it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Ping me when CI is green.
Description of changes
This PR adds mercure package: https://github.com/dunglas/mercure
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)