Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux-firmware: fix build, add explicit revision #245334

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

K900
Copy link
Contributor

@K900 K900 commented Jul 25, 2023

Description of changes

Fixes #245305. Sorry! :(

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions
Copy link
Contributor

Successfully created backport PR for release-23.05:

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 25, 2023
@github-actions
Copy link
Contributor

Backport failed for release-23.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-23.05
git worktree add -d .worktree/backport-245334-to-release-23.05 origin/release-23.05
cd .worktree/backport-245334-to-release-23.05
git checkout -b backport-245334-to-release-23.05
ancref=$(git merge-base 9516089caec5389f2f7e03acf50e4ef2912bb3e9 5a5ddf79cc75e2f10a8d5b5dbaa31587ad8b6883)
git cherry-pick -x $ancref..5a5ddf79cc75e2f10a8d5b5dbaa31587ad8b6883

1 similar comment
@github-actions
Copy link
Contributor

Backport failed for release-23.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-23.05
git worktree add -d .worktree/backport-245334-to-release-23.05 origin/release-23.05
cd .worktree/backport-245334-to-release-23.05
git checkout -b backport-245334-to-release-23.05
ancref=$(git merge-base 9516089caec5389f2f7e03acf50e4ef2912bb3e9 5a5ddf79cc75e2f10a8d5b5dbaa31587ad8b6883)
git cherry-pick -x $ancref..5a5ddf79cc75e2f10a8d5b5dbaa31587ad8b6883

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant