-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
speedtest-exporter: Remove #246320
speedtest-exporter: Remove #246320
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Oh, it was packaged twice?)
I think we should add an entry in aliases.nix.
I disagree. That issue is about having a better/maintained exporter, this PR doesn't do that. I guess you can say "Ref #ISSUE" instead? |
agreed. Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add an entry in aliases.nix to notify users.
b50c2a8
to
1275c43
Compare
1275c43
to
ef96a5a
Compare
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
ef96a5a
to
9738ead
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good
The upstream repository is unmaintained and also has known bugs, so remove the package.
Ref #233062