Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speedtest-exporter: Remove #246320

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

matthiasbeyer
Copy link
Contributor

@matthiasbeyer matthiasbeyer commented Jul 31, 2023

The upstream repository is unmaintained and also has known bugs, so remove the package.

Ref #233062

@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 31, 2023
Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Oh, it was packaged twice?)

I think we should add an entry in aliases.nix.

@bjornfor
Copy link
Contributor

Closes #233062

I disagree. That issue is about having a better/maintained exporter, this PR doesn't do that. I guess you can say "Ref #ISSUE" instead?

@matthiasbeyer
Copy link
Contributor Author

Closes #233062

I disagree. That issue is about having a better/maintained exporter, this PR doesn't do that. I guess you can say "Ref #ISSUE" instead?

agreed. Fixed.

Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add an entry in aliases.nix to notify users.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good

@Janik-Haag Janik-Haag merged commit 96c68c5 into NixOS:master Aug 8, 2023
4 checks passed
@matthiasbeyer matthiasbeyer deleted the remove-speedtest-exporter branch August 8, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants