Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixosTests.pantheon, nixosTests.budgie: Fail the test when coredump happens #249561

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

bobby285271
Copy link
Member

@bobby285271 bobby285271 commented Aug 16, 2023

Description of changes

Both tests succeed for me when a gsettings-desktop-schemas key removal crashes the desktop (see the GNOME 45 PR)

Make these tests fail like this when coredump happens:

subtest: Check if gala has ever coredumped
machine: must fail: coredumpctl --json=short | grep gala
Test "Check if gala has ever coredumped" failed with error: "command `coredumpctl --json=short | grep gala` unexpectedly succeeded"
cleanup
kill machine (pid 8)
machine # qemu-kvm: terminating on signal 15 from pid 6 (/nix/store/jhflvwr40xbb0xr6jx4311icp9cym1fp-python3-3.10.12/bin/python3.10)
(finished: cleanup, in 0.08 seconds)
kill vlan (pid 7)
error: builder for '/nix/store/5gmsbxdmnaxw72hcb6rw9nds8ik24p0n-vm-test-run-pantheon.drv' failed with exit code 1;

(These two desktops for now, I will look into other desktops I maintain later, still need to actually trigger some crash to verify the test)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

It can be possible that pgrep failed to catch this. See the GNOME 45 PR.
This is the shell of the desktop, it is still a good idea to do something with it.
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment labels Aug 16, 2023
@bobby285271
Copy link
Member Author

bobby285271 commented Aug 16, 2023

@ofborg test budgie pantheon

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Aug 16, 2023
@bobby285271 bobby285271 marked this pull request as ready for review August 17, 2023 07:21
@bobby285271
Copy link
Member Author

bobby285271 commented Aug 17, 2023

Since Pantheon can block the channel, I manually grepped dump in the recent hydra runs 1 and don't aware of any coredumps.

Footnotes

  1. https://hydra.nixos.org/job/nixos/trunk-combined/nixos.tests.pantheon.x86_64-linux and https://hydra.nixos.org/job/nixos/trunk-combined/nixos.tests.pantheon.aarch64-linux/

@bobby285271 bobby285271 merged commit 888d0bb into NixOS:master Aug 17, 2023
16 of 18 checks passed
@bobby285271 bobby285271 deleted the fix/fail-test-when-coredump branch August 17, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant