-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ride: init at 4.5.4097 #250627
ride: init at 4.5.4097 #250627
Conversation
lgtm, tho, new version already |
Yeah, I know about the newer versions, however, I'd rather not try to package the |
f82e5e6
to
618ad25
Compare
After looking at the newer versions more closely, I decided to go with the pre-release, as suggested. |
7a87731
to
368cf90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for checking it out |
FYI the build now fails with:
|
Running
Wonder if this might have something to do with it:
|
These helper scripts are inside the upstream repo I'll make some final attempts based on nixpkgs/pkgs/applications/graphics/drawio/default.nix Lines 59 to 61 in 9887be9
Which seems to disable code signing. (This is from one of the few source-built darwin-supported electron apps inside nixpkgs) |
@ofborg build ride |
@eliandoran could you please try to run it once more? |
@TomaSajt , tested on da28cb88fde50cf15f079335342140cd9d5af927 and unfortunately the problem is still there. I propose you mark it as broken for darwin now. Shouldn't be a problem to fix it in the future. |
Alright, I marked it as broken for Darwin. |
cc35532
to
81b7d95
Compare
26f6bba
to
a486260
Compare
Okay, I removed the darwin specific code for now. Once this gets merged, I'll open another PR that adds back those changes. |
Description of changes
This PR adds 1 package:
ride
This name is quite simple so another option could be
dyalog-ride
.Homepage: https://github.com/dyalog/ride
RIDE is a Remote IDE for Dyalog, so Dyalog is not a hard dependency of RIDE.
The package
dyalog
can be found in Nixpkgs, so you can use that for testing out the program.For testing: In the startup window click on the arrow in the top-right corner and put "dyalog" as the executable path (the names of the binaries in
dyalog
.Outside of Nixpkgs, RIDE would detect the installed versions of Dyalog (
/opt/mdyalog
).We could patch this so that it lists the interpreters specified in an attribute. The issue with that is that when the interpreter's store path changes, the old interpreters nix path will remain in the interpreter selection box, and you would have to select the updated interpreter from the dropdown.
We could patch this also, so that if its a
/nix/store/
path, it gets cleared if it isn't specified in the attribute.Anyways, that's outside of the scope of this PR
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)