Init Treedome Package #253047
Closed
Init Treedome Package #253047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagy
suggested changes
Sep 3, 2023
There was a problem hiding this comment.
Thanks, can you follow the guidelines for the commit message at https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#commit-conventions ?
nagy
reviewed
Sep 3, 2023
| runHook postBuild | ||
| ''; | ||
|
|
||
| installPhase = '' |
There was a problem hiding this comment.
This needs runHook preInstall and runHook postInstall.
nagy
reviewed
Sep 3, 2023
| description = "A local-first, encrypted, note taking application with tree-like structures, all written and saved in markdown."; | ||
| homepage = "https://gitlab.com/treedome/treedome"; | ||
| license = licenses.gpl3Plus; | ||
| maintainers = with maintainers; [ tengkuizdihar ]; |
There was a problem hiding this comment.
Can you add mainProgram = "treedome"; ?
|
Will do, sorry this shouldve been a draft pr lol, its not ready yet im
still tinkering with it
…On Sun, 3 Sept 2023, 15:26 Daniel Nagy, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pkgs/applications/misc/treedome/default.nix
<#253047 (comment)>:
> + runHook postBuild
+ '';
+
+ installPhase = ''
+ mkdir -p $out/bin/
+ mkdir -p $out/share/
+
+ cp target/release/bundle/deb/treedome_0.0.0_amd64/data/usr/bin/treedome $out/bin/treedome
+ cp -R target/release/bundle/deb/treedome_0.0.0_amd64/data/usr/share/** $out/share/
+ '';
+
+ meta = with lib; {
+ description = "A local-first, encrypted, note taking application with tree-like structures, all written and saved in markdown.";
+ homepage = "https://gitlab.com/treedome/treedome";
+ license = licenses.gpl3Plus;
+ maintainers = with maintainers; [ tengkuizdihar ];
Can you add mainProgram = "treedome"; ?
—
Reply to this email directly, view it on GitHub
<#253047 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFIOKCU4DL6FWK7743VZKMTXYQ5NBANCNFSM6AAAAAA4JB65AY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
kilianar
reviewed
Sep 4, 2023
| ''; | ||
|
|
||
| meta = with lib; { | ||
| description = "A local-first, encrypted, note taking application with tree-like structures, all written and saved in markdown."; |
There was a problem hiding this comment.
The description should not include a period at the end. See https://nixos.org/manual/nixpkgs/stable/#var-meta-description
(cherry picked from commit cfe3e68)
…-23.11 [Backport release-23.11] stdenvNoLibs: fix typo
(cherry picked from commit a70abc6)
Seems to only occur on some GPUs, e.g. some Intel GPUs. See also bitwarden/clients#6560. Cannot go back to electron 25 easily due to NixOS#272912. Since upstream has a commit to do this, backport it (it does not apply cleanly, though, so vendor). (cherry picked from commit 333dadb)
…-hq/synapse (cherry picked from commit 51edd22)
… with element-hq/synapse (cherry picked from commit 7f7ab04)
…lement-hq/synapse (cherry picked from commit 3d7e5f4)
(cherry picked from commit 60689bf)
(cherry picked from commit ee4176d)
[23.11] wrangler: fix darwin build
…-23.11 [Backport release-23.11] treewide: replace references to matrix-org/synapse with element-hq/synapse
…-23.11 [Backport release-23.11] matrix-synapse: build a pythonEnv out of extraPackages to include dependencies
Fixes CVE-2023-47235 (crash of bgpd on malformed multi-protocol bgp message). Some other notable fixes: ospfd: Fix infinite loop when listing OSPF interfaces zebra: Prevent null pointer dereference Full list of changes: https://frrouting.org/release/9.0.2/ Signed-off-by: Markus Theil <theil.markus@gmail.com>
(cherry picked from commit 403e3db)
[23.11] frr: 9.0.1 -> 9.0.2
…-23.11 [Backport release-23.11] libnvme: apply ns scan payload alignment patch
Fixes CVE-2023-49935, CVE-2023-49936, CVE-2023-49937, CVE-2023-49938, CVE-2023-49933 (cherry picked from commit 9ec60b1)
https://chromereleases.googleblog.com/2023/12/stable-channel-update-for-desktop_12.html This update includes 9 security fixes. CVEs: CVE-2023-6702 CVE-2023-6703 CVE-2023-6704 CVE-2023-6705 CVE-2023-6706 CVE-2023-6707 (cherry picked from commit c29d53b)
https://chromereleases.googleblog.com/2023/12/stable-channel-update-for-desktop_12.html This update includes 9 security fixes. CVEs: CVE-2023-6702 CVE-2023-6703 CVE-2023-6704 CVE-2023-6705 CVE-2023-6706 CVE-2023-6707 (cherry picked from commit 3644340)
Already removed from our tree and nowhere exposed, so no need to keep it here. (cherry picked from commit 5f6dbf8)
(cherry picked from commit aa19ae1)
ChangeLog: https://github.com/nextcloud/server/releases/tag/v26.0.10 (cherry picked from commit 43c07d0)
…:tengkuizdihar/nixpkgs into init_treedome
|
oh no sorry for the spams, should've just rebased it |
github-actions
bot
added
6.topic: python
6.topic: nixos
6.topic: GNOME
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)