Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazecor: init at 1.3.6 #254264

Merged
merged 1 commit into from
Nov 6, 2023
Merged

bazecor: init at 1.3.6 #254264

merged 1 commit into from
Nov 6, 2023

Conversation

amesgen
Copy link
Member

@amesgen amesgen commented Sep 9, 2023

Description of changes

Adapted from the chrysalis derivation.

Things done

  • Built on platform(s)
    • x86_64-linux
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Sep 9, 2023
@dotlambda
Copy link
Member

Please squash.

@delroth delroth added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Sep 14, 2023
@dotlambda
Copy link
Member

Did you try building from source? There are already a few electron apps using yarn in nixpkgs. You could copy from those expressions.

@amesgen
Copy link
Member Author

amesgen commented Sep 15, 2023

Did you try building from source? There are already a few electron apps using yarn in nixpkgs. You could copy from those expressions.

No, I just adapted the chrysalis derivation and thought it would be nice to upstream it; I might look into building it from source in the future when I have time.

@gvolpe
Copy link
Member

gvolpe commented Sep 16, 2023

@dotlambda I did try to build from source a while ago, got stuck with some Electron dependency: Dygmalab/Bazecor#370

@amesgen amesgen changed the title bazecor: init at 1.3.2 bazecor: init at 1.3.4 Oct 8, 2023
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2733

@delroth delroth removed the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Oct 8, 2023
@gvolpe gvolpe requested a review from dotlambda October 9, 2023 09:06
@gvolpe
Copy link
Member

gvolpe commented Oct 9, 2023

@amesgen does this work for you on NixOS? I'm just trying it out and get this error:

Electron's autoUpdater does not support the 'linux' platform
CHECKING BACKUP FOLDER VALUE /home/gvolpe/Dygma/Backups
[4302:1009/151524.287338:ERROR:object_proxy.cc(590)] Failed to call method: org.freedesktop.portal.Settings.Read: object_path= /org/freedesktop/portal/desktop: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.portal.Desktop was not provided by any .service files

Not sure if this is relevant or not, but the Update Firmware option just gives me a blank screen and it seems stuck there. Also, I can't access the configured layers on my Defy either...

@amesgen
Copy link
Member Author

amesgen commented Oct 9, 2023

@amesgen does this work for you on NixOS?

Yes, it works well for my Raise, but I have to reboot after installing it for the first time before it works; otherwise, I get behavior similar to what you describe. Maybe it is enough to restart some udev-related services (but just restarting systemd-udevd.service does not do it) in order to get away without rebooting.

@gvolpe
Copy link
Member

gvolpe commented Oct 9, 2023

@amesgen thanks, I'm still looking at it, might need to raise an issue with them directly. It doesn't work at all with my Dygma Defy (just arrived today), even after restarting my OS 😭

EDIT: I've raised Dygmalab/Bazecor#525, might be helpful to other Defy owners on Linux...

@gvolpe
Copy link
Member

gvolpe commented Oct 11, 2023

@amesgen FWIW I managed to fix my connection issues (details on the issue linked above). TL;DR I needed different udev rules.

@gvolpe
Copy link
Member

gvolpe commented Oct 15, 2023

@amesgen if interested, I came up with a workaround to remove the annoying udev rules check on startup 😄

EDIT: This PR should make it easier if accepted: #261190

@amesgen amesgen changed the title bazecor: init at 1.3.4 bazecor: init at 1.3.5 Oct 21, 2023
@amesgen
Copy link
Member Author

amesgen commented Oct 21, 2023

@amesgen if interested, I came up with a workaround to remove the annoying udev rules check on startup 😄

EDIT: This PR should make it easier if accepted: #261190

Thanks, integrated 👍

@amesgen amesgen changed the title bazecor: init at 1.3.5 bazecor: init at 1.3.6 Oct 26, 2023
Co-authored-by: Gabriel Volpe <volpegabriel@gmail.com>
@gvolpe
Copy link
Member

gvolpe commented Nov 6, 2023

@Artturin I've already approved this two months ago, would be nice to get it merged, thanks 🙏🏽

@Artturin Artturin merged commit a801c0c into NixOS:master Nov 6, 2023
21 of 22 checks passed
@amesgen amesgen deleted the bazecor branch November 6, 2023 10:40
@azuline
Copy link

azuline commented Nov 6, 2023

thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants