Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syft: 0.88.0 -> 0.90.0 #255113

Merged
merged 1 commit into from
Sep 14, 2023
Merged

syft: 0.88.0 -> 0.90.0 #255113

merged 1 commit into from
Sep 14, 2023

Conversation

kashw2
Copy link
Contributor

@kashw2 kashw2 commented Sep 14, 2023

Description of changes

change log: https://github.com/anchore/syft/releases/tag/v0.90.0

diff: anchore/syft@v0.88.0...v0.90.0

changed buildGoModule to use buildGo121Module in all-packages.nix by overwriting the attribute as Syft is now using go 1.21.1
fixed the installCheckPhase by updating ldflags and preBuild ldflags after the pathing for them was changed in anchore/syft#2001

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@kashw2
Copy link
Contributor Author

kashw2 commented Sep 14, 2023

Result of nixpkgs-review pr 255113 run on x86_64-linux 1

1 package built:
  • syft

@techknowlogick
Copy link
Member

Result of nixpkgs-review pr 255113 run on aarch64-darwin 1

1 package built:
  • syft

@fabianhjr fabianhjr merged commit bcd604e into NixOS:master Sep 14, 2023
10 checks passed
@kashw2 kashw2 deleted the syft branch September 14, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants