build-rust-crate: add stripExclude for .rlib #255900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bouk
force-pushed
the
bouk/strip-exclude-rlib
branch
from
afc8760
to
4270524
Compare
This was referenced Sep 18, 2023
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/2675 |
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
|
@SuperSandro2000 done! |
timbertson
approved these changes
Sep 24, 2023
symphorien
approved these changes
Oct 8, 2023
Kranzes
added a commit
to Kranzes/crate2nix
that referenced
this pull request
Jun 11, 2024
Kranzes
added a commit
to Kranzes/crate2nix
that referenced
this pull request
Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This disables stripping .rlib files when building crates, which is needed on macOS because it removes metadata that Rust needs
Follow up to #218783
Fixes #218712
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)