Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regreet: fix user group in tmpfiles rules #257719

Merged
merged 1 commit into from
Oct 2, 2023
Merged

regreet: fix user group in tmpfiles rules #257719

merged 1 commit into from
Oct 2, 2023

Conversation

CardboardTurkey
Copy link
Contributor

Prior to this commit the derivation assumed a user's primary group has the same name as the user themselves. This is standard on linux but not necessary (and indeed I believe not the default on NixOS).

Closes #232184

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@CardboardTurkey
regreet: fix user group in tmpfiles rules
eb2c136 
Prior to this commit the derivation assumed a user's primary group has
the same name as the user themselves. This is standard on linux but not
necessary (and indeed I believe not the default on NixOS).

Closes NixOS#232184
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 27, 2023
@bjornfor
Copy link
Contributor

Prior to this commit the derivation assumed a user's primary group has the same name as the user themselves. This is standard on linux but not necessary (and indeed I believe not the default on NixOS).

WIP fix: #199705

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Sep 27, 2023
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 1, 2023
@RaitoBezarius RaitoBezarius merged commit 6f4a420 into NixOS:master Oct 2, 2023
9 checks passed
@KiaraGrouwstra KiaraGrouwstra mentioned this pull request Jan 29, 2024
Open
@CardboardTurkey CardboardTurkey mentioned this pull request May 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fufexan fufexan fufexan approved these changes

@lilyinstarlight lilyinstarlight Awaiting requested review from lilyinstarlight

@RaitoBezarius RaitoBezarius Awaiting requested review from RaitoBezarius

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

regreet issue with 00-nixos.conf
5 participants
@CardboardTurkey @bjornfor @fufexan @delroth @RaitoBezarius