-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{ruby,neovim}: fix build with content-addressed derivations #258705
Conversation
Wrt #211783, I think this should be a separate parameter for |
Should target staging, follow contributing.md to rebase. Undraft once done. |
I don’t think a rebase is necessary.
|
Remove after NixOS/nixpkgs#258705
This is kind of difficult to review due to the number of rebuilds. Any suggestions for a more limited way to run |
Why do we have |
fwiw I've been testing the ruby side of this for 2 days and haven't had any issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Description of changes
This PR fixes some packages that were broken after #211783 with
contentAddressedByDefault
. See #211783 (comment), #211783 (comment), and #214044 (comment)Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)