buildbot: fix twisted version requirement & missing pkg_resources #263963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Result of 4 packages built:
|
|
nixos test build also |
Lassulus
approved these changes
Oct 28, 2023
Mic92
reviewed
Oct 28, 2023
pkgs/development/tools/continuous-integration/buildbot/master.nix
Outdated
Show resolved
Hide resolved
JulienMalka
force-pushed
the
fix-buildbot
branch
from
47eb672
to
817ede9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Buildbot test is currently broken, see here.
This change fixes it by adding missing
pkg_resourcesand by relaxing dependency ontwisted(buildbot wants a version older than22.10but nixpkgs version is23.8.I think relaxing the dependency is ok in this case: the constraint has been added here, but apparently because otherwise
twistedrequiredzope-interface>=5. The current version ofzope-interfacein nixpkgs is5.5.2so we don't have an issue with that.With this change, the test is passing again.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)