rustc: allow building/git-bisecting without tarballs #266971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
ghost
changed the title
ofborg
bot
added
10.rebuild-darwin: 0
added 2 commits
November 11, 2023 22:12
This commit adds the machinery required to get our `rustc.nix` to work using upstream's git repository, directly, without them waving dead chickens over it and performing whatever other occult rituals are involved in creating a release tarball. No chickens, live or dead, were harmed in the creation of this commit.
This commits adds to the manual a tutorial showing how to troubleshoot breakage caused by a rustc upgrade in *downstream* packages.
ghost
marked this pull request as ready for review
ghost
requested review from
zowoq,
winterqt,
figsoda and
Mic92
as code owners
Mic92
reviewed
Nov 12, 2023
Mic92
approved these changes
Nov 12, 2023
delroth
added
the
12.approvals: 1
Co-authored-by: Jörg Thalheim <Mic92@users.noreply.github.com>
delroth
removed
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This commit adds the machinery required to get our
rustc.nixto work using upstream's git repository, directly, without them waving dead chickens over it and performing whatever other occult rituals are involved in creating a release tarball.This PR also adds to the manual an example of how this functionality can be used to run a
git bisectonrustcin order to find therustccommit that broke some downstream code within nixpkgs.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)