Gnome extensions tophat pathfixes #267160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
more gtop path patches
fix patch paths
github-actions
bot
added
the
6.topic: GNOME
ofborg
bot
added
10.rebuild-darwin: 0
|
(How) does this interact with the GNOME 45 update? |
|
Looking at the porting guide. Most gnome extensions are going to require a rewrite anyway. I think, in that regard, the point is moot. |
|
Hi, GNOME 45 finally got merged. Could you please rebase and test again? |
|
Version in nixpkgs isn't even compatible, so... no? |
|
As of last week, the extension supports Gnome 45 and got updated here in #270315. |
|
Hi! I'm just onboarding on NixOS and had the issue as well. Is this ready to be merged? If not, is there an alternative to the fix? I'm not very familiar with Gnome Extensions but if there is a way I could help with some work on it I'd appreciate some guidance. |
wegank
added
the
2.status: stale
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The tophat gnome extension needs a few more search path patches for gtop to get settings to work.
Things done
Built on platform(s)
[*] Tested basic functionality of all binary files (usually in
./result/bin/)Add path fixes to prefs.js and lib/shared.js
Options are now available again in the extension.