nixos/invoiceplane: add nginx as a webserver option #267519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b12f
changed the title
b12f
force-pushed
the
feat/nginx-for-invoiceplane
branch
from
a36b2cd
to
5fc5b02
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/2925 |
|
@ofborg build nixosTests.invoiceplane |
b12f
force-pushed
the
feat/nginx-for-invoiceplane
branch
from
5fc5b02
to
1ee7483
Compare
|
Good suggestions @SuperSandro2000, thanks for the review. I've applied your changes. |
Getting the vhost to play nice with phpfpm was done by following this community post: https://community.invoiceplane.com/t/topic/2654
b12f
force-pushed
the
feat/nginx-for-invoiceplane
branch
from
1ee7483
to
a7f4774
Compare
teutat3s
approved these changes
Nov 16, 2023
|
@ofborg build nixosTests.invoiceplane |
b12f
changed the title
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1385 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This adds nginx as an option for
services.invoiceplane.webserver. I've tested this on my own instance.Getting the vhost to play nice with phpfpm was done by following this community post: https://community.invoiceplane.com/t/topic/2654
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)