slack: 4.34.121 -> 4.35.126

[infinisil]

Description of changes

This fixes blank screen rendering issues, this was the error message on stderr for context:

[9759:1127/165648.468472:ERROR:shared_context_state.cc(83)] Skia shader compilation error

Followed by a million lines of shader source code

This needs to be backported because the release version currently has the same problem

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

[infinisil]

@ofborg build slack

[infinisil]

I believe this is also a case of #244742. Updating seems to fix it though, so no need for a workaround

[amaxine]

Does this actually resolve the issue, or is this just a side effect of doing an update and (I'm guessing here) possibly invalidating the cache? Of course we should update and backport regardless, just wondering whether this long-term truly resolves the problem.

[infinisil]

@amaxine Oh yeah, I think it's just a side effect. Comparing the logs before and after this change, I notice:

+[11/27/23, 17:02:03:365] info: Boots up new service worker version 
 {
   "scriptUrl": "https://app.slack.com/service-worker.js",
   "scope": "https://app.slack.com/",
   "renderProcessId": 4,
-  "versionId": 3
+  "versionId": 4
 }

[amaxine]

Can you fix up the commit to remove the mention of this fixing the issue? Don't wanna be misleading 🙂

ofborg won't build this anyway since it's nonfree. Looks good when building locally. Thank you for doing the update.

[infinisil]

@amaxine Good point, did that!

[github-actions]

Successfully created backport PR for release-23.11:

• [Backport release-23.11] slack: 4.34.121 -> 4.35.126 #270451

[github-actions]

Successfully created backport PR for release-23.05:

• [Backport release-23.05] slack: 4.34.121 -> 4.35.126 #274995

[github-actions]

Backport failed for release-23.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-23.11
git worktree add -d .worktree/backport-270440-to-release-23.11 origin/release-23.11
cd .worktree/backport-270440-to-release-23.11
git switch --create backport-270440-to-release-23.11
git cherry-pick -x 5075c3f6ec5c40d10ca3c4b5e2ca0353d1ee7fd4