Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agdaPackages.standard-library: 1.7.3 -> 2.0 #273765

Merged
merged 4 commits into from
Dec 28, 2023

Conversation

ncfavier
Copy link
Member

https://github.com/agda/agda-stdlib/blob/v2.0/CHANGELOG.md

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: agda "A dependently typed programming language / interactive theorem prover" label Dec 12, 2023
@turion
Copy link
Contributor

turion commented Dec 12, 2023

@ofborg build agdaPackages.standard-library.passthru.tests

EDIT(@ncfavier): retrigger

Copy link
Contributor

@alexarice alexarice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add the --include-deprecated flag on the call to GenerateEverything.hs. This means that if you use a deprecated module the warnings actually show up instead of giving an error about things not being built

@turion
Copy link
Contributor

turion commented Dec 13, 2023

It seems that this would break agda-categories. Can we give them some time & warning to update their library before merging?

@turion
Copy link
Contributor

turion commented Dec 13, 2023

Upstream issue is agda/agda-categories#405, if there is no progress in, say, a week or so, I'm happy to merge. But if there is some promising progress, I think we should bump both libraries jointly.

@alexarice
Copy link
Contributor

It's worth noting that this version is a large non backwards compatible change

@ncfavier
Copy link
Member Author

Sure, I wasn't planning to merge this right away. agdarsec and functional-linear-algebra are also failing; opened gallais/agdarsec#33 and ryanorendorff/functional-linear-algebra#50.

@delroth delroth added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Dec 13, 2023
@ryanorendorff
Copy link
Contributor

Updated the functional-linear-algebra package to work with the 2.0 version of the library. Thanks for the heads up.

@ncfavier
Copy link
Member Author

Can confirm HEAD builds. Are you planning to make a new release or should we bump to HEAD?

@ryanorendorff
Copy link
Contributor

ryanorendorff commented Dec 23, 2023

Just pushed tag v0.5.0 (which is HEAD), so if that could be used that would be great. Thanks!

@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 23, 2023
@ofborg ofborg bot requested a review from alexarice December 23, 2023 22:09
@alexarice
Copy link
Contributor

agda-categories has a new release, so we can probably go ahead with this update now

@ncfavier
Copy link
Member Author

ncfavier commented Dec 27, 2023

Bumped agda-categories. No response from agdarsec, so we might as well mark it broken.


I had to increase the maximum heap for building agda-categories after the update. Weirdly enough, this is the third Agda project I know of that has recently started exceeding the maximum heap size (the other two being agda-unimath and 1lab), but this doesn't seem to be correlated to the Agda 2.6.4.1 bump... Does anyone have an explanation, or is this just a funny coincidence?

@turion
Copy link
Contributor

turion commented Dec 28, 2023

Does anyone have an explanation, or is this just a funny coincidence?

It might be worth checking whether this is due to the recent agda version bump, the agda-stdlib version bump, or the agda-categories version bump. I have no explanation, though.

@alexarice
Copy link
Contributor

Could it also be a ghc change? I always remember agda being happy to consume way more than 4gb ram

@ncfavier ncfavier merged commit 6eaf979 into NixOS:haskell-updates Dec 28, 2023
22 of 23 checks passed
@ncfavier ncfavier deleted the agda-stdlib branch December 28, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: agda "A dependently typed programming language / interactive theorem prover" 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants