Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slskd: 0.18.2 -> 0.19.5 #281233

Merged
merged 1 commit into from
Jan 17, 2024
Merged

slskd: 0.18.2 -> 0.19.5 #281233

merged 1 commit into from
Jan 17, 2024

Conversation

melvyn2
Copy link
Contributor

@melvyn2 melvyn2 commented Jan 15, 2024

Description of changes

Major: https://github.com/slskd/slskd/releases/tag/0.19.0
Patch: https://github.com/slskd/slskd/releases/tag/0.19.5

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ppom0
Copy link
Contributor

ppom0 commented Jan 16, 2024

Hi @melvyn2, Do you want to add yourself as a maintainer too?

@melvyn2
Copy link
Contributor Author

melvyn2 commented Jan 17, 2024

Thank you for the invitation! I'll add myself in the refactor PR instead to keep this one focused.

@yayayayaka yayayayaka merged commit 148cff9 into NixOS:master Jan 17, 2024
28 checks passed
@melvyn2 melvyn2 deleted the update-slskd branch January 17, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants