programs.zsh: move evlauation of ${zshAliases} after cfg.interactiveShellInit

[Ma27]

Motivation for this change

⚠️ Caution: (possible) BC Break: This changes the order of operations in /etc/zshrc which might break several people's setups.

cfg.interactiveShellInit is used by modules like
programs.zsh.oh-my-zsh. This means that all aliases defined in
programs.zsh.shellAliases might be overriden which is highly
unpredictable in some cases.

Example:

oh-my-zsh overrides ll and l aliases in the core (no plugin which might be disabled), but I decided to use exa as ls replacement.
Now I tried to alias ls and ll to exa in programs.zsh.shellAliases, but it was overriden by oh-my-zsh as interactiveShellInit is evaluated after shellAliases.

A quickfix was to use mkAfter:

{
 programs.zsh.interactiveShellInit = pkgs.lib.mkAfter ''
   alias ls="${pkgs.exa}/bin/exa";
 '';
}

As you can see I create alias statements manually in a custom interactiveShellInit block, however I don't think that such hacks should be necessary to prevent such unexpectable behavior.

Things done

• Tested using sandboxing
  (nix.useSandbox on NixOS,
  or option build-use-sandbox in nix.conf
  on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • Linux
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Fits CONTRIBUTING.md.

---

[Ma27]

thanks :)