Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/rabbitmq: prefer 'install' over 'mkdir/chmod/chown' #284117

Merged
merged 2 commits into from
Feb 5, 2024
Merged

nixos/rabbitmq: prefer 'install' over 'mkdir/chmod/chown' #284117

merged 2 commits into from
Feb 5, 2024

Conversation

Stunkymonkey
Copy link
Contributor

@Stunkymonkey Stunkymonkey commented Jan 26, 2024 •
edited
Loading

Description of changes

part of #121293

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 26, 2024
@Stunkymonkey Stunkymonkey mentioned this pull request Jan 26, 2024
Open
42 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Jan 26, 2024
@roberth
nixos/rabbitmq: Rename cookie -> unsafeCookie
6761394 
Not a mkRenamedOptionModule, because user intervention is required
to determine whether they have a problem. mkRenamed* does not let
us explain anything to the user.
@roberth
Copy link
Member

roberth commented Feb 5, 2024

cc @turion - rabbitmq package maintainer.

I've renamed the cookie option to unsafeCookie, without deprecation cycle because nobody should be using this option in a production environment anyway.

roberth
roberth approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@roberth roberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good now, but I'm a co-author of the PR now, so I'd appreciate some eyes on my own changes; the rename.

@roberth roberth merged commit 274ae6a into NixOS:master Feb 5, 2024
20 checks passed
@roberth
Copy link
Member

roberth commented Feb 5, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberth roberth roberth approved these changes

@turion turion turion approved these changes

@edef1c edef1c Awaiting requested review from edef1c

@binarin binarin Awaiting requested review from binarin

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Stunkymonkey @roberth @turion