Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvmPackages_git: 18.0.0-unstable-2023-12-13 -> 18.1.0-rc3 #285786

Merged
merged 7 commits into from
Feb 22, 2024

Conversation

wegank
Copy link
Member

@wegank wegank commented Feb 2, 2024

Description of changes

In addition to patch updates, other commits have been applied to follow the upstream changes:

Also, llvm/llvm-project@48e5b5e breaks the libcxxabi/libunwind separation in Nixpkgs when useLLVM = true, and is therefore reverted.

Tested by:

  • Building llvmPackages_git on x86_64-linux, aarch64-linux, aarch64-darwin, plus building and running hello with llvmPackages_git.stdenv.
  • Building llvmPackages_git.llvm on x86_64-darwin.
  • Building and running pkgsLLVM.hello with llvmPackages_git on x86_64-linux.
  • Building pkgsStatic.llvmPackages_git.clang and pkgsCross.wasi32.llvmPackages_git.libcxx with ofborg.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@wegank wegank force-pushed the llvm-git-rc1 branch 2 times, most recently from 53d1f75 to a40f69c Compare February 2, 2024 12:15
@wegank wegank changed the title llvmPackages_git: refresh patches llvmPackages_git: 18.0.0-unstable-2023-10-04 -> 18.1.0-rc1 Feb 2, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Feb 2, 2024
@wegank wegank force-pushed the llvm-git-rc1 branch 5 times, most recently from b717cb2 to 9cc3f25 Compare February 2, 2024 18:04
@ofborg ofborg bot added the ofborg-internal-error Ofborg encountered an error label Feb 2, 2024
@wegank
Copy link
Member Author

wegank commented Feb 2, 2024

@ofborg eval

@wegank
Copy link
Member Author

wegank commented Feb 2, 2024

@ofborg build llvmPackages_git

@wegank wegank marked this pull request as ready for review February 3, 2024 10:43
@wegank wegank marked this pull request as draft February 5, 2024 16:34
@wegank wegank force-pushed the llvm-git-rc1 branch 2 times, most recently from 7a2f5ca to 30a27a4 Compare February 6, 2024 20:38
@wegank wegank changed the title llvmPackages_git: 18.0.0-unstable-2023-10-04 -> 18.1.0-rc1 llvmPackages_git: 18.0.0-unstable-2023-12-13 -> 18.1.0-rc1 Feb 6, 2024
@wegank wegank force-pushed the llvm-git-rc1 branch 2 times, most recently from a835879 to f1ef0f9 Compare February 6, 2024 20:44
@wegank
Copy link
Member Author

wegank commented Feb 6, 2024

@ofborg build pkgsStatic.llvmPackages_git.clang

@wegank
Copy link
Member Author

wegank commented Feb 6, 2024

@ofborg build pkgsCross.wasi32.llvmPackages_git.libcxx

@wegank wegank marked this pull request as ready for review February 7, 2024 00:16
@wegank wegank marked this pull request as draft February 7, 2024 13:17
@wegank wegank marked this pull request as ready for review February 7, 2024 13:46
@wegank wegank changed the title llvmPackages_git: 18.0.0-unstable-2023-12-13 -> 18.1.0-rc1 llvmPackages_git: 18.0.0-unstable-2023-12-13 -> 18.1.0-rc2 Feb 7, 2024
@wegank wegank removed the ofborg-internal-error Ofborg encountered an error label Feb 7, 2024
@wegank wegank changed the title llvmPackages_git: 18.0.0-unstable-2023-12-13 -> 18.1.0-rc2 llvmPackages_git: 18.0.0-unstable-2023-12-13 -> 18.1.0-rc3 Feb 21, 2024
@wegank wegank merged commit 27d33c3 into NixOS:master Feb 22, 2024
34 of 36 checks passed
@wegank wegank deleted the llvm-git-rc1 branch February 22, 2024 17:01
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants