Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/pyload: add user/group options #287304

Merged
merged 1 commit into from
Feb 10, 2024
Merged

nixos/pyload: add user/group options #287304

merged 1 commit into from
Feb 10, 2024

Conversation

ambroisie
Copy link
Contributor

Description of changes

I have a use case which needs to set the group, which is quite annoying to do at the moment.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Feb 8, 2024
@ambroisie ambroisie requested a review from pbsds February 8, 2024 20:26
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Feb 8, 2024
@pbsds
Copy link
Member

pbsds commented Feb 9, 2024

Should umask be configurable as well?

@ambroisie
Copy link
Contributor Author

I think Umask is much easier to override (just one option in the service configuration), and I personally don't have a need for it 🤷.

@pbsds pbsds merged commit 6f55f02 into NixOS:master Feb 10, 2024
22 checks passed
ambroisie added a commit to ambroisie/nix-config that referenced this pull request Feb 29, 2024
@ambroisie
flake: bump inputs
b9b47ff 
Fix the pyLoad user/group option that I added upstream [1].

Fix an evaluation error due to Pipewire changes [2].

[1]: NixOS/nixpkgs#287304
[2]: NixOS/nixpkgs#282377
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbsds pbsds Awaiting requested review from pbsds

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ambroisie @pbsds