Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openjpeg: 2.5.0 -> 2.5.2 #291683

Merged
merged 1 commit into from
Feb 29, 2024
Merged

openjpeg: 2.5.0 -> 2.5.2 #291683

merged 1 commit into from
Feb 29, 2024

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Feb 26, 2024

Changes:

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 27, 2024
@trofi trofi marked this pull request as draft February 27, 2024 22:05
@trofi
Copy link
Contributor Author

trofi commented Feb 27, 2024

Converting to draft: might have caused ghostscript and python3.11-pillow build failures like:

./base/sjpx_openjpeg.c:763:13: error: too few arguments to function 'opj_stream_set_user_data'
  763 |             opj_stream_set_user_data(state->stream, &(state->sb));
      |             ^~~~~~~~~~~~~~~~~~~~~~~~

@trofi
Copy link
Contributor Author

trofi commented Feb 27, 2024

Upstream issue: uclouvain/openjpeg#1514

@trofi trofi changed the title openjpeg: 2.5.0 -> 2.5.1 openjpeg: 2.5.0 -> 2.5.2 Feb 29, 2024
@trofi trofi marked this pull request as ready for review February 29, 2024 09:38
@trofi
Copy link
Contributor Author

trofi commented Feb 29, 2024

2.5.2 is released to address missing include. Ready for review.

@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 29, 2024
@vcunat vcunat merged commit 820d018 into NixOS:staging Feb 29, 2024
26 of 27 checks passed
Copy link
Contributor

Successfully created backport PR for staging-23.11:

@trofi trofi deleted the openjpeg-update branch February 29, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants