Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lan-mouse: init at 0.6.0 #292333

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Conversation

PedroHLC
Copy link
Member

@PedroHLC PedroHLC commented Feb 29, 2024

Description of changes

Adds https://github.com/feschber/lan-mouse

Another promising KVM that should work with Wayland…

EDIT: Tested and it works between sway<->sway

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Previous non-nixpkgs attempts (this PR was not based on them):


Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@eclairevoyant eclairevoyant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback below.

Also, the program fails to start on my end. strace indicates that it can't find the applicable socket:

socket(AF_UNIX, SOCK_STREAM|SOCK_CLOEXEC, 0) = 10
connect(10, {sa_family=AF_UNIX, sun_path="/run/user/1000/lan-mouse-socket.sock"}, 39) = -1 ENOENT (No such file or directory)
close(10)

pkgs/by-name/la/lan-mouse/package.nix Show resolved Hide resolved
pkgs/by-name/la/lan-mouse/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/la/lan-mouse/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/la/lan-mouse/package.nix Outdated Show resolved Hide resolved
@PedroHLC
Copy link
Member Author

PedroHLC commented Feb 29, 2024

Also, the program fails to start on my end. strace indicates that it can't find the applicable socket:

I'm testing it here with a simple nix run .#lan-mouse and with nix build .#lan-mouse over two systems running latst nixos-unstable. Is that in a service?

EDIT: Maybe it was the lack of GIO due to not being used wrapGAppsHook (at that point).

@eclairevoyant
Copy link
Contributor

eclairevoyant commented Feb 29, 2024

Also, the program fails to start on my end. strace indicates that it can't find the applicable socket:

Is that in a service?

No, I'm running directly from the terminal. No GUI opens, and the output is as follows:

$ result/bin/lan-mouse
[2024-02-29T14:00:36Z WARN  lan_mouse::config] /home/user/.config/lan-mouse/config.toml: No such file or directory (os error 2)
[2024-02-29T14:00:36Z WARN  lan_mouse::config] Continuing without config file ...
[2024-02-29T14:00:36Z WARN  lan_mouse::config] /home/user/.config/lan-mouse/config.toml: No such file or directory (os error 2)
[2024-02-29T14:00:36Z WARN  lan_mouse::config] Continuing without config file ...
[2024-02-29T14:00:36Z INFO  lan_mouse] Press Ctrl+Alt+Shift+Super to release the mouse
[2024-02-29T14:00:36Z INFO  lan_mouse::consumer] using wlroots event consumer
[2024-02-29T14:00:36Z INFO  lan_mouse::producer] libei event producer not available: not implemented
[2024-02-29T14:00:36Z INFO  lan_mouse::producer] using layer-shell event producer
[2024-02-29T14:00:36Z ERROR lan_mouse] io error: No such file or directory (os error 2)

And I tested this with the gtk wrapper.

@PedroHLC
Copy link
Member Author

PedroHLC commented Feb 29, 2024

Is that in a service?

No, I'm running directly from the terminal. No GUI opens, and the output is as follows:

And I tested this with the gtk wrapper.

Interesting, you're using the same consumers as I, but it works here, from terminal or not. (and that sock is flawlessly created)

@itslychee
Copy link
Contributor

1 package built:
lan-mouse

Result of nixpkgs-review pr 292333 run on x86_64-linux 1

1 package built:
  • lan-mouse

I'm currently on swayfx and this starts fine for me.

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 29, 2024
Copy link
Contributor

@eclairevoyant eclairevoyant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must be a config issue on my end, I can run this fine on my Arch system but not NixOS.

One more change to pass CI:

pkgs/by-name/la/lan-mouse/package.nix Outdated Show resolved Hide resolved
@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 29, 2024
@eclairevoyant eclairevoyant dismissed their stale review February 29, 2024 21:32

I'll approve if CI is happy with it

@superherointj superherointj merged commit 4c26a89 into NixOS:master Mar 2, 2024
23 checks passed
@PedroHLC PedroHLC deleted the lan-mouse-init branch March 2, 2024 12:40
@feschber
Copy link
Contributor

@PedroHLC Hi, heres the developer of lan-mouse. I'm not too familiar with nix. Do I open a pr to get the version updated?

@superherointj
Copy link
Contributor

Do I open a pr to get the version updated?

Yes.

@feschber
Copy link
Contributor

#298010

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants