rPackages.opencv: fixed build #293081
Merged
rPackages.opencv: fixed build #293081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 0
Kupac
suggested changes
Mar 5, 2024
There was a problem hiding this comment.
It builds, but something is still missing:
ocv_display(faces)
Error: OpenCV(4.9.0) /build/source/modules/highgui/src/window.cpp:1255: error: (-2:Unspecified error) The function is not implemented. Rebuild the library with Windows, GTK+ 2.x or Cocoa support. If you are on Ubuntu or Debian, install libgtk2.0-dev and pkg-config, then re-run cmake or configure script in function 'cvNamedWindow'
In addition, native and buildInputs should be split correctly.
|
I've added |
Kupac
suggested changes
Mar 7, 2024
|
Ok, think I got it, the error message was related to opencv, not the R package. So I needed to override opencv to build with gtk2 support (thanks to https://stackoverflow.com/a/53757886). That seems to have done the trick, could you test it on your end as well? |
|
OK, I'm building it on x86_64 Linux. If someone could check on darwin, that would be awesome. Not sure they have gtk there? Does it need Cocoa or something? |
Kupac
approved these changes
Mar 9, 2024
delroth
added
the
12.approvals: 1
13 tasks
|
Confirm it compiles and is functional on
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixed build and tested basic functionality.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.