antlr: symlink jar instead of copying #293178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this also allows for using the jarLocation as a standalone file without pulling in a Java runtime from the wrapper scripts.
|
@NickCao are you the right person for antlr (there's no-one in maintainers)? What do you think? The rebuilds can also be reduced if we only change jarLocation and not antlr (at the very small cost of duplicating the small jar file). |
|
I like this idea, and frankly less than 100 rebuilds ain't much. |
|
Result of 8 packages marked as broken and skipped:
9 packages failed to build:
46 packages built:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This separates the antlr-4.13.0-complete.jar file from antlr package which creates wrapper scripts.
With this separation, we can use the jar by itself without pulling in a whole Java runtime.
This is useful when the jar needs to be used in other environments.
Description of changes
Link instead of copy in the installPhase, and jarLocation is changed to use the .jar file directly instead of from the wrapper package.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.