Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport staging-23.11] go_1_21: 1.21.6 -> 1.21.8 #293764

Closed
wants to merge 1 commit into from
Closed

[Backport staging-23.11] go_1_21: 1.21.6 -> 1.21.8 #293764

wants to merge 1 commit into from

Conversation

katexochen
Copy link
Contributor

@katexochen katexochen commented Mar 6, 2024 •
edited
Loading

Changelog: https://go.dev/doc/devel/release#go1.21.0

Signed-off-by: Paul Meyer 49727155+katexochen@users.noreply.github.com
(cherry picked from commit 5b02c75)

Description of changes

Manual backport of #293563

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@katexochen
go_1_21: 1.21.7 -> 1.21.8
a616ac5 
Changelog: https://go.dev/doc/devel/release#go1.21.0

Signed-off-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
(cherry picked from commit 5b02c75)
@katexochen katexochen added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Mar 6, 2024
@ofborg ofborg bot requested review from qbit and mfrw March 6, 2024 15:19
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 6, 2024
@delroth delroth added 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Mar 7, 2024
@vcunat vcunat changed the title [Backport staging-23.11] go_1_21: 1.21.7 -> 1.21.8 [Backport staging-23.11] go_1_21: 1.21.6 -> 1.21.8 Mar 7, 2024
vcunat pushed a commit that referenced this pull request Mar 7, 2024
@katexochen @vcunat
go_1_21: 1.21.6 -> 1.21.8 (PR #293764)
5881a44 
Changelog: https://go.dev/doc/devel/release#go1.21.0

Signed-off-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
(cherry picked from commit 5b02c75)
@vcunat
Copy link
Member

vcunat commented Mar 7, 2024

Included in staging-next-23.11 (PR #293976). I just cherry-picked it, as I wanted to also correct the version in commit message.

@vcunat vcunat closed this Mar 7, 2024
@katexochen katexochen deleted the backport-293563-to-staging-23.11 branch March 7, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@mfrw mfrw mfrw approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit kalbasit is a code owner

@Mic92 Mic92 Awaiting requested review from Mic92 Mic92 is a code owner

@zowoq zowoq Awaiting requested review from zowoq zowoq is a code owner

@qbit qbit Awaiting requested review from qbit

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: golang 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@katexochen @vcunat @mfrw @SuperSandro2000 @delroth