-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix and simplify stylesheets for the manuals, fix nrd bug #295847
Conversation
e86034a
to
de7eddb
Compare
This is very good. Maybe throw in a Nix logo for good measure like in NixOS/nix#9870 I'd merge as is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed this in the docs team meeting today:
Looks like there's a minor problem with examples (in the NixOS manual here):
Whereas before it was
Also make sure to check the options listing, it's a separate page that perhaps uses separate CSS classes.
And some potential future improvements
-
Less rounded corners
-
No shadow for code samples
-
Improve header font size, especially in
lib
, might need some adjustments tofont-size
, or switching it torem
instead of percentages (cc @hsjobeki)
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-03-14-documentation-team-meeting-notes-113/41462/1 |
75f5b75
to
4291bac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything I mentioned above has been addressed, however I spotted a new problem: The options page has odd left/right margins:
The empty space on the right is only visible if I scroll. Seems better on smaller screens.
If you have the time to fix this that would be great, but otherwise I can also merge already :)
I tried to look into it for a fixed amount of time, but couldn't find what's causing that. When the browser has enough width, the scroll bar doesn't show up, but as I reduced the browser's width, I could reproduce this behaviour. My guess is that there is some content in this page that is causing this behaviour, but I can't find the content because there is just too much there. I looked into |
Alright let's not worry about it for now then, this is already much better than the current state, so let's merge! |
Successfully created backport PR for |
Description of changes
As discussed in NixOS/nixos-homepage#1251, the Nixpkgs and NixOS manuals are now being rendered as-is on the new website. This "breaks" the manuals, because previously we relied on a very complex post-processing step (which was done on the homepage's repository) to get the manuals as we're all used to. This included using the stylesheets from the old homepage.
Since we can't rely on that anymore, I went through the trouble of understanding the steps that were being done in the old homepage, figuring out the final stylesheet rules, and then translating those rules back to the manuals as generated by Nixpkgs. This was done to avoid having to do all those complex steps anymore, I just want to simplify things.
As part of this simplification:
overrides.css
stylesheet anymore, so I merged all stylesheets into one.Note: the new stylesheets are not absolutely 1:1 with the old stylesheets, which relied on more stuff from the old homepage that I don't want to port over (mainly the custom fonts). In addition to that, I modified the stylesheets a bit to address this comment: NixOS/nixos-homepage#1251 (comment)
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.