Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/nextcloud: remove opcache.enable_cli=1 #295932

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Conversation

Kranzes
Copy link
Member

@Kranzes Kranzes commented Mar 14, 2024

Description of changes

Upstream no longer recommends enabling the opcache cli.

See the following:

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Upstream no longer recommends enabling the opcache cli.
See the following:
 - nextcloud/documentation#1439
 - nextcloud/server#15468
Copy link
Member

@e1mo e1mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From skimming the linked PRs this seems sensible 👍

@Kranzes Kranzes merged commit 09078fd into NixOS:master Mar 14, 2024
24 checks passed
@Ma27
Copy link
Member

Ma27 commented Mar 14, 2024

From what I see, this is a bugfix and stable users would benefit from that as well -> backporting.

Copy link
Contributor

Successfully created backport PR for release-23.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants