Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opam: use aspcud on darwin #29719

Merged
merged 1 commit into from
Sep 24, 2017
Merged

opam: use aspcud on darwin #29719

merged 1 commit into from
Sep 24, 2017

Conversation

winniequinn
Copy link
Contributor

Motivation for this change

aspcud is the recommended solver for OPAM and the aspcud package is now building properly on Darwin. As such, we can remove the special case for Darwin that required OPAM to fall back to the built-in solver.

Note: The failure related to the csv package mentioned in #29336 has been fixed and nox-review now passes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

aspcud is the recommended solver for OPAM and the `aspcud` package is
now building properly on Darwin. As such, we can remove the special case
for Darwin that required OPAM to fall back to the built-in solver.
@mention-bot
Copy link

@winniequinn, thanks for your PR! By analyzing the history of the files in this pull request, we identified @aske, @hakuch and @henrytill to be potential reviewers.

@Mic92 Mic92 merged commit baa55a4 into NixOS:master Sep 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants