meson: 1.3.2 -> 1.4.0 #298047
Merged
meson: 1.3.2 -> 1.4.0 #298047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
requested review from
bobby285271,
AndersonTorres and
FedericoSchonborn
This only worked because Meson has, until now, disabled warnings for C code transpiled from Vala. It will no longer be doing this going forward. Link: BuddiesOfBudgie/budgie-desktop-view#28
AndersonTorres
approved these changes
Mar 24, 2024
This comment was marked as outdated.
This comment was marked as outdated.
AndersonTorres
approved these changes
Mar 26, 2024
wegank
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Tested building lots of packages, including every Vala package I could find as of a few weeks ago because of mesonbuild/meson@5f659af870011e.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.